commit | 334fb112459f785a9d6721f5b332df63fe7262c2 | [log] [tgz] |
---|---|---|
author | Phillis Tang <phillis@chromium.org> | Thu Jun 16 00:55:21 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Jun 16 00:55:21 2022 |
tree | 8dc76be87d39a1bc53be57aeed0b3a81d038f5fc | |
parent | a0d8d4e3f64694ab179c954eb0403bc0b2ee48c3 [diff] |
Revert "[WPT] BFCache: service worker clients" This reverts commit 756b8281b5b76b2ae4561d3cf8c29a46689cf23f. Reason for revert: New tests are very flaky. Example: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVylgELEgVGbGFrZSKKAWNocm9taXVtQGJsaW5rX3dlYl90ZXN0c0BleHRlcm5hbC93cHQvaHRtbC9icm93c2Vycy9icm93c2luZy10aGUtd2ViL2JhY2stZm9yd2FyZC1jYWNoZS9zZXJ2aWNlLXdvcmtlci1jb250cm9sbGVkLWFmdGVyLXJlc3RvcmUuaHR0cHMuaHRtbAw https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyjgELEgVGbGFrZSKCAWNocm9taXVtQGJsaW5rX3dlYl90ZXN0c0BleHRlcm5hbC93cHQvaHRtbC9icm93c2Vycy9icm93c2luZy10aGUtd2ViL2JhY2stZm9yd2FyZC1jYWNoZS9zZXJ2aWNlLXdvcmtlci1jbGllbnRzLW1hdGNoYWxsLmh0dHBzLmh0bWwM Original change's description: > [WPT] BFCache: service worker clients > > This CL adds service worker tests for BFCache: > > - navigator.serviceWorker.controller > - Fetch interception > - Clients.claim() > - Clients.matchAll() and > - unregister(). > > Expected behavior: > > - Controlled pages should remain controlled after > restored from BFCache, i.e. > navigator.serviceWorker.controller should remain non-null > and fetch should be intercepted. > - Clients.claim() should evict pages > that would be affected from BFCache. > - Clients.matchAll() shouldn't list pages in BFCache. > - unregister() should evict controlled pages from BFCache. > > Failing tests: > > - service-worker-clients-claim.https.html: > On Safari/Firefox, Clients.claim() doesn't evict pages from BFCache. > - service-worker-controlled-after-restore.https.html: > On Firefox, fetches are not intercepted after restored from > BFCache while `navigator.serviceWorker.controller` is non-null. > - service-worker-unregister.https.html: > Controlled pages aren't evicted by unregister() (all browsers). > > Bug: 1107415, 1204228, https://github.com/w3c/ServiceWorker/issues/1594 > Change-Id: I73233cf917e31dd91b974823d5490d0190f0eade > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3201011 > Reviewed-by: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Ben Kelly <wanderview@chromium.org> > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1008327} Bug: 1107415, 1204228, https://github.com/w3c/ServiceWorker/issues/1594 Change-Id: I56ac20a492e2b1716d27867dc9c113b097833a6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3708190 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Phillis Tang <phillis@chromium.org> Auto-Submit: Phillis Tang <phillis@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/main@{#1014735}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.