Fixing a bug in determining tab to select in a split view The compare function provided to max_element has the largest element as the first parameter followed by the current element. So the logic needs to be reversed. This kind of worked previously due to the fact that we call SelectTab on both MousePressed and MouseReleased events. However, there are two issues that still show up. First is clicking on a tab while the split view is active would cause a tab switch (added a regression test for this). Second, the tab with the focus would be incorrect. Bug: 408011094 Change-Id: I2acc4798a6ed6211e07ce4dc3b56bec387da7efb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6455992 Commit-Queue: Eshwar Stalin <estalin@chromium.org> Reviewed-by: Alison Gale <agale@chromium.org> Cr-Commit-Position: refs/heads/main@{#1447162}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.