Reland^3 "protobuf: Use deps instead of public_deps" This reverts commit ce86d97bbc5f93154f5c8d36364dc20bd5233645. Reason for revert: WIP Fix for internal builder https://crrev.com/i/8284216 was submitted. Bug: 402356473 Original change's description: > Revert "Reland^2 "protobuf: Use deps instead of public_deps"" > > This reverts commit 76607be42637a4b642b7fe26493f36c86a210cd9. > > Reason for revert: > Broke internal builder > https://ci.chromium.org/ui/p/chrome/builders/try/linux-chrome-dbg-cog-cache-warmer/35870/overview > > Bug: 402356473 > Original change's description: > > Reland^2 "protobuf: Use deps instead of public_deps" > > > > This reverts commit 3cd6191c4631a1b945ff3e9380938c32b028d46c. > > > > Reason for revert: > > Fixed deps usages in existing proto_library targets in other CLs. > > > > Bug: 402356473 > > Original change's description: > > > Revert "Reland "protobuf: Use deps instead of public_deps"" > > > > > > This reverts commit e567bc892e22cfe5f9f3c217e4450b506cb9f241. > > > > > > Reason for revert: > > > https://ci.chromium.org/ui/p/chromium/builders/build/linux-chromeos-build-perf-siso/8798/overview > > > > > > Bug: 402356473 > > > Original change's description: > > > > Reland "protobuf: Use deps instead of public_deps" > > > > > > > > This reverts commit b0ee510d564e53836bd38d66465b17a295e67a5d. > > > > > > > > Reason for revert: > > > > Fixed missing deps in existing proto_library targets in other CLs. > > > > > > > > Original change's description: > > > > > Revert "protobuf: Use deps instead of public_deps" > > > > > > > > > > This reverts commit 7b491de370a1d917fd356b63286becf57b754a87. > > > > > > > > > > Reason for revert: > > > > > This causes many fallbacks due to missing deps in developer builds. > > > > > e.g. > > > > > ``` > > > > > [13608/59426] 56.85s F ACTION //components/feed/core/proto:proto_v2_gen(//build/toolchain/linux:clang_x64) > > > > > FAILED: 65bff3cf-b4b4-4d1f-92ae-0d56c0a28436 "./gen/components/feed/core/proto/v2/keyvalue_store.pb.h" ACTION //components/feed/core/proto:proto_v2_gen(//build/toolchain/linux:clang_x64) > > > > > err: remote-exec d8c97f78dad6e63d7c3a33d371fff11438596f1eac7a641244eb1d8d18eefb04/355 failed: exit=1 > > > > > python3 ../../tools/protoc_wrapper/protoc_wrapper.py components/feed/core/proto/v2/keyvalue_store.proto components/feed/core/proto/v2/packing.proto components/feed/core/proto/v2/store.proto components/feed/core/ > > > > > proto/v2/ui.proto components/feed/core/proto/v2/user_actions_store.proto components/feed/core/proto/v2/wire/action_diagnostic_info.proto components/feed/core/proto/v2/wire/action_payload.proto components/feed/co > > > > > re/proto/v2/wire/action_surface.proto components/feed/core/proto/v2/wire/capabilities_debug_data.proto components/feed/core/proto/v2/wire/capability.proto components/feed/core/proto/v2/wire/chrome_client_info.pr > > > > > oto components/feed/core/proto/v2/wire/chrome_fulfillment_info.proto components/feed/core/proto/v2/wire/client_info.proto components/feed/core/proto/v2/wire/client_user_profiles.proto components/feed/core/proto/ > > > > > v2/wire/code.proto components/feed/core/proto/v2/wire/column_types.proto components/feed/core/proto/v2/wire/consistency_token.proto components/feed/core/proto/v2/wire/content_id.proto components/feed/core/proto/ > > > > > v2/wire/content_lifetime.proto components/feed/core/proto/v2/wire/cui_server_metadata.proto components/feed/core/proto/v2/wire/data_operation.proto components/feed/core/proto/v2/wire/device.proto components/feed > > > > > /core/proto/v2/wire/diagnostic_info.proto components/feed/core/proto/v2/wire/display_info.proto components/feed/core/proto/v2/wire/duration.proto components/feed/core/proto/v2/wire/error_details.proto components > > > > > /feed/core/proto/v2/wire/eventid.proto components/feed/core/proto/v2/wire/expiration_info.proto components/feed/core/proto/v2/wire/feature.proto components/feed/core/proto/v2/wire/feed_action.proto components/fe > > > > > ed/core/proto/v2/wire/feed_entry_point_data.proto components/feed/core/proto/v2/wire/feed_entry_point_source.proto components/feed/core/proto/v2/wire/feed_query.proto components/feed/core/proto/v2/wire/feed_requ > > > > > est.proto components/feed/core/proto/v2/wire/feed_response.proto components/feed/core/proto/v2/wire/feed_streaming.proto components/feed/core/proto/v2/wire/info_card.proto components/feed/core/proto/v2/wire/lang > > > > > uage_preferences.proto components/feed/core/proto/v2/wire/next_page_token.proto components/feed/core/proto/v2/wire/payload_metadata.proto components/feed/core/proto/v2/wire/reliability_logging_enums.proto compon > > > > > ents/feed/core/proto/v2/wire/render_data.proto components/feed/core/proto/v2/wire/request.proto components/feed/core/proto/v2/wire/request_schedule.proto components/feed/core/proto/v2/wire/response.proto compone > > > > > nts/feed/core/proto/v2/wire/server_experiment_data.proto components/feed/core/proto/v2/wire/stream_structure.proto components/feed/core/proto/v2/wire/table.proto components/feed/core/proto/v2/wire/there_and_back > > > > > _again_data.proto components/feed/core/proto/v2/wire/timestamp.proto components/feed/core/proto/v2/wire/token.proto components/feed/core/proto/v2/wire/upload_actions_request.proto components/feed/core/proto/v2/w > > > > > ire/upload_actions_response.proto components/feed/core/proto/v2/wire/version.proto components/feed/core/proto/v2/wire/view_demotion_profile_extension.proto components/feed/core/proto/v2/wire/web_feed_id.proto co > > > > > mponents/feed/core/proto/v2/wire/web_feed_identifier_token.proto components/feed/core/proto/v2/wire/web_feed_matcher.proto components/feed/core/proto/v2/wire/web_feed_token.proto components/feed/core/proto/v2/wi > > > > > re/web_feeds.proto components/feed/core/proto/v2/wire/xsurface_container.proto components/feed/core/proto/v2/wire/xsurface_content.proto components/feed/core/proto/v2/xsurface.proto --protoc ./protoc --proto-in- > > > > > dir ../../ --cc-out-dir gen/ --py-out-dir pyproto/ > > > > > build step: __components_feed_core_proto_proto_v2_gen___build_toolchain_linux_clang_x64__rule "./gen/components/feed/core/proto/v2/keyvalue_store.pb.h" > > > > > siso_rule: proto/protoc_wrapper > > > > > stdout: > > > > > components/feed/core/proto/v2/wire/chrome_feed_response_metadata.proto: File not found. > > > > > ../../components/feed/core/proto/v2/wire/feed_response.proto:10:1: Import "components/feed/core/proto/v2/wire/chrome_feed_response_metadata.proto" was not found or had errors. > > > > > ../../components/feed/core/proto/v2/wire/feed_response.proto:34:12: "ChromeFeedResponseMetadata" is not defined. > > > > > ../../components/feed/core/proto/v2/wire/response.proto:9:1: Import "components/feed/core/proto/v2/wire/feed_response.proto" was not found or had errors. > > > > > ../../components/feed/core/proto/v2/wire/response.proto:19:12: "FeedResponse" is not defined. > > > > > ../../components/feed/core/proto/v2/wire/web_feeds.proto:11:1: Import "components/feed/core/proto/v2/wire/response.proto" was not found or had errors. > > > > > ../../components/feed/core/proto/v2/wire/web_feeds.proto:96:3: "Response" is not defined. > > > > > ../../components/feed/core/proto/v2/store.proto:13:1: Import "components/feed/core/proto/v2/wire/web_feeds.proto" was not found or had errors. > > > > > ../../components/feed/core/proto/v2/store.proto:315:3: "feedwire.webfeed.WebFeedChangeReason" is not defined. > > > > > Protoc has returned non-zero status: 1 > > > > > > > > > > ``` > > > > > > > > > > Original change's description: > > > > > > protobuf: Use deps instead of public_deps > > > > > > > > > > > > With this change, we can remove unnecessary inputs dependency from ninja > > > > > > build files. > > > > > > > > > > > > Bug: 402356473 > > > > > > Change-Id: Icf4bc72c6e511ffd459a2aa6a335699d27fbe821 > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6414089 > > > > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > > > > > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > > > > > > Cr-Commit-Position: refs/heads/main@{#1443879} > > > > > > > > > > Bug: 402356473 > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Change-Id: I7d2d0aee49d32bfdcb3385ec0236d0f5b04b648a > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6437993 > > > > > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > > > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > > > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > > > > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > > > > > Cr-Commit-Position: refs/heads/main@{#1443928} > > > > > > > > Bug: 402356473 > > > > Cq-Include-Trybots: luci.chromium.try:linux-centipede-asan-rel > > > > Change-Id: Ia7bce5df2126319b94c022854043dff44e143e7c > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6442961 > > > > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > > > Cr-Commit-Position: refs/heads/main@{#1460512} > > > > > > Bug: 402356473 > > > Cq-Include-Trybots: luci.chromium.try:linux-centipede-asan-rel > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Change-Id: Ic98ea3b208bf261596b6e95ef72145a3be1c80de > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6551215 > > > Reviewed-by: Minoru Chikamune <chikamune@chromium.org> > > > Owners-Override: Minoru Chikamune <chikamune@chromium.org> > > > Commit-Queue: Minoru Chikamune <chikamune@chromium.org> > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > > Cr-Commit-Position: refs/heads/main@{#1460521} > > > > Bug: 402356473 > > Cq-Include-Trybots: luci.chromium.try:linux-centipede-asan-rel > > Cq-Include-Trybots: luci.chromium.try:linux-chromeos-asan-rel > > Change-Id: Ia4df24c3f18dc750b874e5aef58ffdd18df43961 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6550637 > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1462550} > > Bug: 402356473 > Cq-Include-Trybots: luci.chromium.try:linux-centipede-asan-rel > Cq-Include-Trybots: luci.chromium.try:linux-chromeos-asan-rel > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Change-Id: Ib7e15b7a2eaff6a234fccfc76422f22373f4e0bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6565991 > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Reviewed-by: Sophie Chang <sophiechang@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1462583} Bug: 402356473 Cq-Include-Trybots: luci.chromium.try:linux-centipede-asan-rel Cq-Include-Trybots: luci.chromium.try:linux-chromeos-asan-rel Cq-Include-Trybots: luci.chrome.try:optimization_guide-linux Change-Id: I51795ca33c2c085bf658ad3e6aeed533ac38ac42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6563931 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Sophie Chang <sophiechang@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/main@{#1463093}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.