Redo AmbientControllerTest.ShouldDismissScreenSaverPreviewOnTouch.

It fails when TimeOfDay is default enabled, but it's not really
because of TimeOfDay. It comes down to the fact that the video
screen saver can start rendering immediately, whereas the slide
show screen saver must wait for photos to be downloaded. The test
case was not waiting for the ambient ui to start rendering:
* Ambient session is started
* PressTouch
* Ambient session is closed
* Ambient session starts again somehow
* ReleaseTouch
* Ambient session closes again

This sequence is unrealistic. It requires a user to exit ambient
mode by touching the screen, hold their finger on
the screen the entire time, and while doing so, somehow relaunch
ambient mode, then release their finger afterwards. Even if that
somehow happens, it's not clear that the intended behavior is for
the release to trigger ambient session closing again. It does not
work for video because this happens instead:
* Ambient session is launched
* Ambient widget/window is created
* PressTouch
* Ambient widget/window is closed
* Ambient session is closed
* A TOUCH_CANCELED is automatically generated since the PressTouch
  closed the widget while the widget was still active.
* Ambient session starts again somehow.
* ReleaseTouch.
* The GestureRecognizer deep in the ui code does not publish
  the ReleaseTouch to the AmbientController because the original
  PressTouch event was canceled previously when the widget was
  destroyed.

The fix is to give the test a realistic sequence of events and
make sure that touching the screen exits ambient mode while it
is preparing photos and while it is rendering.

Bug: b:292294050
Change-Id: Idb696016a8a4864232fc95d9039435cc69023d61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4713674
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Eric Sum <esum@google.com>
Cr-Commit-Position: refs/heads/main@{#1175151}
5 files changed
tree: 8e265da6735d1d36efa110f5d2f2f4b3dcdb4864
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.