Google Git
Sign in
chromium / chromium / src / e99b4ff46490e4878155550c995df571760deded
commite99b4ff46490e4878155550c995df571760deded[log] [tgz]
authorWojciech Dzierżanowski <wdzierzanowski@opera.com>Mon Oct 17 19:37:15 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Oct 17 19:37:15 2022
tree8fd49185a5b9fd4e9b0a3a3fe3d11b5be71c3d11
parent14710d816855487f6c573d0b2db6d8ebce574f35 [diff]
Set error status once in RTCVideoEncoder::Impl

RTCVideoEncoder::Impl should set the signaled value once.
NotifyAndLogError() does that, after figuring out the most appropriate
error status. If the signaled value is also set explicitly, only one of
the values set will actually take effect.

One example where this led to unexpected behavior is when
RTCVideoEncoder::Impl::EncodeOneFrameWithNativeInput() detects bad frame
storage type. If WEBRTC_VIDEO_CODEC_ERROR is set explicitly, the caller
of RTCVideoEncoder::Encode() sees that status instead of the
WEBRTC_VIDEO_CODEC_FALLBACK_SOFTWARE status that is really expected
here.

Bug: 1375235
Change-Id: Ib5d1683044df4edd07fc7803330defa3b36a874d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3959577
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Auto-Submit: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1060098}
2 files changed
tree: 8fd49185a5b9fd4e9b0a3a3fe3d11b5be71c3d11
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.