Google Git
Sign in
chromium / chromium / src / e9c369517c24af2d166ef5d8c2d959ec780d1bee
commite9c369517c24af2d166ef5d8c2d959ec780d1bee[log] [tgz]
authorScott Yoder <scottyoder@google.com>Tue Feb 21 22:42:44 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Feb 21 22:42:44 2023
tree7b80d4a544b50919c7dd9d2dee517a602bd52754
parentaac6509826e79e19910ea389022d5cb5f4421385 [diff]
[ios] Fix issue with EG tests and device orientation

The issue appears to have been caused by a roll to EarlGrey on Feb
24, 2023. This appears to be the change that caused the issue:
https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+/16d0e8218db438513ffd95ba9425908703a19b4d

The change appears to have removed a request for UIDevice to update the
device orientation, which caused UIDevice's orientation property to be
UIDeviceOrientationUnknown. This caused an error when the test was in tear down when it tried to return the device to its original orientation. However, we can get the orientation from XCUIDevice
instead.

Fixed: 1416561,1416228
Change-Id: I4ecd2fa45736b9b74c844374fb6edf7321369626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4265373
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Scott Yoder <scottyoder@google.com>
Cr-Commit-Position: refs/heads/main@{#1107971}
3 files changed
tree: 7b80d4a544b50919c7dd9d2dee517a602bd52754
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.