Fix computation of caret rect alignment when unicode-bidi: plaintext

In |NGCaretRect::ComputeLocalCaretRectAtTextOffset|, the caret position
corresponding to that text offset is first computed, and then it is
clamped to a bounding box that depends on the line box rect and the
line's container. This bounding box depends on the line's text
alignment, as computed by the |ShouldAlignCaretRight| function.

However, the |should_align_caret_right| variable has an additional
condition, such that if the unicode-bidi CSS property is set to
plaintext, that variable can only be true if the cursor is in an LTR
text fragment, regardless of the text alignment. There are no comments
explaining why this extra condition is needed, and it seems to have
been added as part of https://crrev.com/c/2234323 with no reasoning
attached.

This extra condition makes |should_align_caret_right| be false whenever
the cursor is pointing into RTL text, which can make a difference as
shown in the added test. It is also the underlying cause behind
https://crbug.com/1278559. This patch removes this condition.

Bug: 1349390
Change-Id: I0167a4259bf65a10a3f3694d431bbe5421ab6425
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3805880
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Andreu Botella <abotella@igalia.com>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1032492}
2 files changed
tree: 8198ebe796a8b70b1aa2884596072aa3b3eb68d2
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.