Lacros: Simplify handling of system URLs

- Get rid of the custom os:// URL parsing/santization code. Thanks to
  changes a while ago, we never need to sanitize an os:// URL while
  keeping it an os:// URL. Hence we can just convert it to a chrome://
  URL first and then sanitize that.
- Also split URL sanitization from Lacros-to-Ash conversion for clarity
  and avoiding duplicate work. Do sanitiziation only where it matters,
  namely in UrlHandlerAsh.
- Make Ash's CanHandleUrl and UrlHandlerAsh expect an Ash URL. Do the
  conversion at call sites if needed.
- Simplify OsUrlHandlerSystemWebAppDelegate::IsUrlInSystemAppScope
  based on the above.
- Rename some functions for clarity and consistency.
- Remove/update some outdated documentation.
- Remove an obsolete code path from lacros_url_handling's
  IsUrlAcceptedByAsh. It was needed for older Ash, which are now
  outside the supported version skew range.

This is in preparation for addressing the referenced bug.

Bug: chromium:1445145
Change-Id: I3eb734859fae264587d8e9241963a4de59d33888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4914773
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1214624}
17 files changed
tree: fbc22195b869a8785965f6aa7776c0181c47f830
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.