[iOS][UNOp2] Add EGTests/unittests for Upgrade promo metrics and prefs This patch adds test for crrev.com/c/4925234. Related to: crbug.com/1491096. Unittests in TwoScreensSigninCoordinatorTest makes sure no upgrade promo metrics/prefs are updated when TwoScreensSigninCoordinator is created with another the access point than ACCESS_POINT_SIGNIN_PROMO. EGTests in UpgradeSigninPromoTestCase checks that the upgrade promo updates upgrade promo metrics/prefs, with kReplaceSyncPromosWithSignInPromos flag enabled. This patch had to move constants from user_signin_constants.h and upgrade_signin_logger.mm to signin_constants.h, so they can be used in unittests and EGTests. Also `-[ChromeEarlGrey userDefaultObjectForKey:]` is added. Bug: 1470750 Change-Id: I0e25228b595fb4325176dd54667853f7043631af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4931414 Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/main@{#1210095}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.