AX: Improve CanSetFocusAttribute performance by caching the result.

This patch caches CanSetFocusAttribute result and uses it when needed.

Note that this doesn't follow the typical pattern of updating the cache
because this value can change in response to a new style update,
independently of the ax cache modification count.

Also, this is a fairly heavy function which is not always needed, so
having it be computed in the general cache update can cause a
performance degradation

Perf test results:
test: third_party/blink/perf_tests/accessibility/many-nodes-toggle-content-visibility-auto.html
no patch: 6839ms
patch: 5917ms (-13%)

test: third_party/blink/perf_tests/accessibility/many-nodes-toggle-content-visibility-hidden.html
no patch: 5139ms
patch: 4681ms (-9%)


R=aleventhal@chromium.org, chrishtr@chromium.org

Bug: 1264610
Change-Id: Ie8574ae28baa81d8d2be738560bf0a5a81fdd2bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3252717
Commit-Queue: vmpstr <vmpstr@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937192}
2 files changed
tree: ea4fdcbe88851116e396f710510a41a896e95444
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.