Google GitGoogle Git
Sign in
chromium/chromium/src/ea93a1386e441c8296cf217aae3e4b94fcc10d95
commit
ea93a1386e441c8296cf217aae3e4b94fcc10d95
[log]
author
Ted Meyer <tmathmeyer@chromium.org>
Mon May 04 21:13:17 2020
committer
Commit Bot <commit-bot@chromium.org>
Mon May 04 21:13:17 2020
tree
270336ccd62b17c67b3294a2abdcb46e177452ad
parent
b541b0255120c0aeb0b12987d0babef1ae3711e1 [diff]
Fix memory leak in MediaInternalsProxy.

MediaInternalsProxy is refcounted, so base::BindRepeating keeps it
alive, which means that the bound callback never gets deleted.

Bug: 1076810
Change-Id: I9cdb12a99f8a3ddeaa1c13a0232a2cf1a9d8d78b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174656
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#765254}
3 files changed
tree: 270336ccd62b17c67b3294a2abdcb46e177452ad
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. ENG_REVIEW_OWNERS
  68. LICENSE
  69. LICENSE.chromium_os
  70. OWNERS
  71. PRESUBMIT.py
  72. PRESUBMIT_test.py
  73. PRESUBMIT_test_mocks.py
  74. README.md
  75. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.