Use the opener document execution context during media player creation This change fixes a bug where the browser would crash when a video element is moved into a Picture in Picture window and a new player is created for it. The new player would retrieve a media inspector context that is associated with the PiP window. Once the PiP window is closed the media inspector context becomes a candidate for garbage collection. The crash takes place once the media inspector context is garbage collected and a subsequent media log generated. This change fixes the issue by using the media element opener document execution context, when needed, during player creation. A side effect is that when the opener document execution context is used, media logs will not be visible from the PiP DevTools panel, however this aligns with other decisions to delegate responsibility to the opener (e.g. https://crbug.com/40866464). Bug: 377728959 Change-Id: I70f87c480189fdf665ff9bebca806c7608316118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038314 Reviewed-by: Tommy Steimel <steimel@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Benjamin Keen <bkeen@google.com> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391394}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.