WebUI: Make cr-lottie Worker TrustedTypes compliant, attempt 2.

The previous attempt at crrev.com/c/4039783/ only partially achieved its
stated goal. It modified the creation of cr-lottie's web worker to be
TrustedTypes compliant, but the worker itself was throwing a TT related
error asynchronously, which was unfortunately missed by tests.

During the attempt to enable TrustedTypes CSP checks on
chrome://webui-test/ where cr-lottie's unit tests are running from, it
was discovered that the worker was not actually working as expected, on
contexts with TT checks enabled (like chrome://settings).

Fixing by migrating away from importScripts(), and loading cr-lottie's
worker wrapper script as an ES module, which in turn allows it to import
the actual worker script using the following import statement

import 'chrome://resources/lottie/lottie_worker.min.js';

which does not trigger the TT related error thrown by importsScripts().
In order for this to work, also had to add chrome://resources in the
'worker-src' CSP of every WebUI page that uses cr-lottie.

Bug: 1098690,1385477
Fixed: 1399335
Change-Id: I204f7efd741ca5f2f7aeb4385dfa21dc20c59a82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4086647
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1080990}
9 files changed
tree: bbaf2bf6960562b788707db24a63102b571b5861
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.