Google Git
Sign in
chromium / chromium / src / eb639ff12768d77c136bb138c998f23911b202af
commiteb639ff12768d77c136bb138c998f23911b202af[log] [tgz]
authorTim Sergeant <tsergeant@chromium.org>Thu Jul 27 02:36:45 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 27 02:36:45 2023
treea6e5b0056f887c3d7385b7c2be7668ef30d6fed0
parentca30db5353e9052a45f8b58f739cfd5057be8284 [diff]
App Management: Remove PreferredAppsList reference to avoid UAF in tests

App Management uses the PreferredAppsList from App Service to listen to
and modify preferred apps settings. In Lacros tests which use a real Ash
process, App Service is reset between tests, and so the stored reference
to PreferredAppsList can become invalid when App Service restarts.

As a simple fix, we change App Management to read the PreferredAppsList
from App Service every time it is needed.

Note that I haven't been able to reliably figure out which Lacros test
is starting App Management, it seems like it might be flaky, which is in
itself a bit worrying.

Bug: 1466885
Change-Id: I16e8dce9ac814e7837e17b074a328cc13c9f1a5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4721909
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1175821}
2 files changed
tree: a6e5b0056f887c3d7385b7c2be7668ef30d6fed0
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.