Fix dangling ptrs in UpdateApplicationDockMenu test UpdateApplicationDockMenu was previously creating Browser obejcts, passing pointers to BrowserWindow unique_ptrs that were destroyed sortly after. The result was Browser objects with dangling BrowserWindow pointers. This CL corrects this by ensuring BrowserWindow unique_ptrs are persisted and destroyed only after their associated Browser has been destroyed. Bug: 417766643 Change-Id: I968c773971cd4722abc987e60baefaad5a46c70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6605059 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Tom Lukaszewicz <tluk@chromium.org> Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/main@{#1467519}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.