Google Git
Sign in
chromium / chromium / src / eb9c3dda0b5a99bf17fc151fd943ebedfce8025d
commiteb9c3dda0b5a99bf17fc151fd943ebedfce8025d[log] [tgz]
authorDavid Maunder <davidjm@google.com>Fri Apr 11 19:47:09 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 11 19:47:09 2025
tree5bc8a176802af0f231dcdb7412e618ae8103f05f
parentf1b2d6bde4384f588ac3e4fa7d5b78a69adfe7cc [diff]
[M136] Don't show ShopCard for same URL once engaged with

This CL adds support in ImpressionsLimitService to log if a ShopCard
for a specific url has been engaged with (i.e. tapped on). This data
is externalized via a public API to provide support for not
displaying ShopCards which have been engaged with. This is so
we don't clutter the Magic Stack with a ShopCard which has already
been engaged with as well as give the opportunity for other ShopCards
to be generated (i.e. if the user has price drops on multiple URLs).
Support is also added for resetting the ShopCard and fetching the
next ShopCardItem (if applicable) if the user taps on the ShopCard.

(cherry picked from commit 635bdcdafb9df73b4988c44e336caf0286845ec0)

Bug: 409397983
Fixed: 409999747
Change-Id: I73573141c8f33a3d63f239300e87a44a77b60e65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6441728
Commit-Queue: David Maunder <davidjm@chromium.org>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1444737}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6450722
Cr-Commit-Position: refs/branch-heads/7103@{#702}
Cr-Branched-From: e09430c64983fc906f37a9f7e6806275c9b67b86-refs/heads/main@{#1440670}
5 files changed
tree: 5bc8a176802af0f231dcdb7412e618ae8103f05f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.