commit | eb9de038b9d60fd365329bb1480cd2b2e115fae0 | [log] [tgz] |
---|---|---|
author | Dominique Fauteux-Chapleau <domfc@google.com> | Fri Sep 09 18:28:23 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Sep 09 18:28:23 2022 |
tree | a4eef3d36cc3518fb0874632bfa7b8f1616fc6eb | |
parent | 524ede51b650115243d73f6a68045578cbcc8047 [diff] |
Revert "Unified Side Panel: Add image search key/value to json struct." This reverts commit dec15ed8f48265ad21bbd4ec4463a5e4c3372345. Reason for revert: breaks on linux-chromeos-chrome, see https://ci.chromium.org/ui/p/chrome/builders/ci/linux-chromeos-chrome/24737/overview Original change's description: > Unified Side Panel: Add image search key/value to json struct. > > Added a new image search param to the json file and will use that to direct image search and region search requests to the unified side panel for search engines. > > Design Doc: go/unified-side-panel-non-google-dse > > - Direct 3P DSE requests to side panel only if the image search param exists and the unified side panel is turned on. > - If the unified side panel flag is turned off, the 3P DSE requests are redirected to a new tab. > - For lens requests, standardize the way rendering env variable query param gets added. > - Use default vector image search icon for the 3P DSE's. > - Changing Search Engine when side panel is opened closes side panel and de-registers lens. > > For testing purposes, enabled side panel for Bing search engine and here are the demos: > > Region Search: https://drive.google.com/file/d/1wKde02oZL6EeFCJYwdPLfKo_p9qST-mE/view > > Image Search: https://drive.google.com/file/d/116hIj5fWda_hKZ_2VHa-L50gNWMsjAg9/view > > Changing Search Engine: https://drive.google.com/file/d/1lgO7yUV-pA6jpSXH6gZdFVT7-vGfqXh3/view > > NOTE: The existing browser tests for the lens unified side panel are broken, so did not add new browser tests for 3P DSE's, we will add them when fixing the browser tests in b/242909164. > > Bug: b/226186680 > Change-Id: I268eb7d673e02d6a0a77838280f1c7014367f314 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3866097 > Commit-Queue: Anudeep Palanki <apalanki@google.com> > Reviewed-by: Ali Stanfield <stanfield@google.com> > Reviewed-by: Evan Stade <estade@chromium.org> > Reviewed-by: Orin Jaworski <orinj@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1045182} Bug: b/226186680 Change-Id: I2bb922204f51bdb012eb6c0be120f76e1029e8c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3887281 Owners-Override: Dominique Fauteux-Chapleau <domfc@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dominique Fauteux-Chapleau <domfc@google.com> Auto-Submit: Dominique Fauteux-Chapleau <domfc@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1045241}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.