| commit | ebc8ef7a77d89087c457f101b2ff7e099d200082 | [log] [tgz] |
|---|---|---|
| author | Martin Kreichgauer <martinkr@google.com> | Wed Feb 19 23:48:58 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Feb 19 23:48:58 2025 |
| tree | 6d5ae3631b1b97dd5f791c2e8001f76ebb9ea0c0 | |
| parent | 423fc2e2304d347b0c96af11629df41812c1b59a [diff] |
webauthn: move PasskeyUpgradeRequestController into dialog controller I originally envisioned we would want to keep PasskeyUpgradeRequestController instances alive beyond the lifetime of the WebAuthn request and thus made its own DocumentUserData. But that isn't actually a requirement. And not having the controller scoped to the request lifetime means it needs to observe some state from the dialog model and deal with resetting itself after a request finishes. Instead, just have the dialog controller own the upgrade controller to simplify things. Change-Id: Ie8c291859d3dcd046df936f1128ff6cb378dd219 Bug: 377758786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6261750 Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/main@{#1422255}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.