Google GitGoogle Git
Sign in
chromium/chromium/src/ebd4d7e6bd9ea8640719b6088b52a7112996bf91
commit
ebd4d7e6bd9ea8640719b6088b52a7112996bf91
[log]
author
Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Wed Nov 24 21:40:59 2021
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Wed Nov 24 21:40:59 2021
tree
db4150fbaf37dc11648872abdda53adbd5ba4649
parent
5275b433fbc35b91d05f72f175b21582e858c1e8 [diff]
[Extensions] Fix a crash when moving pinned extensions

The crash happens due to a failed DCHECK when moving around
force-pinned extensions. Force-pinned extensions, unlike others, don't
get saved in the kPinnedExtensions pref.

For now, just fix the crash by preventing force-pinned extensions from
getting moved, and never trying to move other extensions into the
"force-pinned group" to the right. This isn't intuitive, but it's
better than crashing the browser as a temporary measure.

Bug: 1266952, 1266958
Change-Id: I106d002a940d3f610701da3263de9969c92038f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3282309
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#945125}
2 files changed
tree: db4150fbaf37dc11648872abdda53adbd5ba4649
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.