Google Git
Sign in
chromium / chromium / src / ec04e3818f93a212203044ca7dd1a01d57766cda
commitec04e3818f93a212203044ca7dd1a01d57766cda[log] [tgz]
authorWilliam Liu <liuwilliam@chromium.org>Thu May 23 18:03:27 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu May 23 18:03:27 2024
tree0299c4fbe2f691046d66788ab4d9d531e3e05b62
parent2f66df4b95bc1feb1b52b7dd78cd0b5b55280c77 [diff]
[content] Add GoToIndexAndReturnPrimaryMainFrameRequest.

Introduce a content-internal GoToIndex() variant that returns the
created NavigationRequest in the primary main frame, if any.

The rationale is: currently there is no definitive way of knowing if a
GoToIndex() call has successfully created a primary main frame
navigation request.

With the new API there is no need to fetch the request from the
FrameTreeNode for a cross-doc navigation and fetch the request from the
RFHI for a same-doc navigation. Note: this new API won't return the
requests from the subframe navigations even if they are created.

See http://docs/document/d/1-LxDYRKvzRbl9WQhfHm6IudGu9y7MbHknMT2-EomQeA

Bug: 41491318
Change-Id: I4944de155bece0aa2fda2ce24b66e1ca78e664d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5539136
Reviewed-by: Khushal Sagar <khushalsagar@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: William Liu <liuwilliam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1305216}
2 files changed
tree: 0299c4fbe2f691046d66788ab4d9d531e3e05b62
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.