Google Git
Sign in
chromium / chromium / src / ec085cef6a9ba74bcb2299229c9f7ce5d9769d36
commitec085cef6a9ba74bcb2299229c9f7ce5d9769d36[log] [tgz]
authorssid <ssid@chromium.org>Fri Dec 13 17:31:26 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Dec 13 17:31:26 2024
tree77e2d38f662c2ccf900ca525c74f999f2dfb4e3f
parent0ff562a032421e2047806f1044e90da517b92da2 [diff]
Refactor educational tips to work with merged ranking

We need more clean up in educational tips code base to remove the
Tip enum and use a single enum. This will be done in follow ups.

- Make each tip a different module so its cleaner to handle ranking
  logic in one place.
- Enable support for showing multiple ephemeral cards in ntp.
- Deprecate EDUCATIONAL_TIP module type. And Fix the logic related to
  iterating enums incrementally, added utility to fetch active modules.
- Remove special case handling of EDUCATIONAL_TIP module in magic stack
  code base, only the ranker deals with the complexity for ephemeral
  modules.
- Move the logic to notify card being shown and card clicked into home
  delegate and the home mediator sends these to native.
  onModuleClicked() and onModuleBuilt() already existed.

Bug: 382803396

Change-Id: I16f0dd5ac316b90ff36e064dc57caf20d19e251e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6089471
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xinyi Ji <xinyiji@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>
Reviewed-by: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1396019}
22 files changed
tree: 77e2d38f662c2ccf900ca525c74f999f2dfb4e3f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.