[CrOS Bluetooth] Fix AdapterStateController rapid enable toggling.

Fix issue in AdapterStateController where if Bluetooth is enabled,
then rapidly disabled, Bluetooth will re-enable itself. This is because
when BluetoothAdapter::SetPowered() finishes and its success callback
is fired, momentarily, the value it returns in
BluetoothAdapter::IsPowered() is still the old value. Therefore, when
AdapterStateController attempts to perform the next queued state change
(disable) once the success callback finishes, it believes the adapter
is already disabled because SetPowered() returns false, and performs
no action, leaving the adapter in its current state (enabled). The UI
updates to reflect the still-enabled-state, giving the impression that
Bluetooth has re-enabled.

This CL updates AdapterStateController to not attempt to perform the
next queued state change when the success callback is fired, instead
waiting until AdapterPoweredChanged() is called to ensure the adapter
is in the correct state before performing the next state change.

Bug: 1010321
Change-Id: I0cdd871d5452730838f1e74b13de39ef663efc32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3309686
Commit-Queue: Gordon Seto <gordonseto@google.com>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Auto-Submit: Gordon Seto <gordonseto@google.com>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#946787}
2 files changed
tree: f16e5fd77315e8c263b3b3a6bbedb7b7825e69b7
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.