[windows services] Fix shutdown races

- Do not keep the initial service thread alive for the lifetime of the
  service. There is no requirement to do so, and ordinary COM services
  do not need this thread for any reason. Delegates that provide their
  own Run() method may choose to keep the thread alive if they wish.
- Call PreRun/PostRun on the process's main thread rather than on the
  initial service thread since they should be called on the same thread
  and the initial service thread isn't suitable due to the fact that it
  is no longer kept running.
- Since there is no longer a concept of the "service main thread" there
  is no "current" sequence/thread task runner available when the
  delegate's various methods are invoked. As such, the updater service
  now runs its own SingleThreadTaskExecutor in its Run method.
- Set the module release callback before registering com class objects,
  as it's possible that another thread could rapidly process a request
  and trigger module release.
- Use a lock around all state associated with shutdown to be sure that
  there are no data races in those scenarios.
- Avoid thread hops before telling the SCM that the service has stopped.
  Any delay appears to increase errors by high-frequency callers.
- Move registration of an empty FeatureList into ServiceProgramMain so
  that it's alongside other generic process initialization.
- Move the tracing service's IPC thread and mojo setup into its
  delegate's PreRun/PostRun since that is now a logical/suitable place
  to do so.

Fixed: 375097840
Change-Id: Icc71ed3cd6a825097e8ce0c445df536b72f877dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6026072
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Auto-Submit: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1384972}
11 files changed
tree: 6ec50fe97b3b4a497ee4fd68b8901cbb2a049545
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.