commit eca15c2024a59599e91d76afe9ee89468e21393b
author Greg Thompson <grt@chromium.org> Wed Mar 23 13:04:16 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Mar 23 13:04:16 2022
tree 7ec3504525abca1077a15735d01826ded100027e
parent ac33cf6997da9a0ca60d52ef1f0040bd1ee44e21

[fuchsia] More test target script improvements.

- EmuTarget and DeviceTarget each now call `ffx target remove` (if
  needed) before shutting down the emulator or breaking contact with the
  device, respectively. This is an attempt to resolve flakiness whereby
  the ffx daemon gets wedged.

- DeviceTarget now only uses `fx target add` when given a host:port
  pair if the target isn't already known. This allows repeat uses of a
  persistent emulator that is not using TUN/TAP (e.g.,
  `start_emulator.py --without-network`)

- Moved the basic implementation of EmuTarget._IsEmuStillRunning into
  QemuTarget since the implementation is specific to the lifecycle of
  qemu-based emulators. (FvdlTarget already has its own implementation.)

- Moved the bulk of EmuTarget.Shutdown into QemuTarget since the
  implementation is specific to the lifecycle of qemu-based emulators.
  (FvdlTarget already has its own implementation.)

- Moved statistic logging from EmuTarget.Shutdown (which is responsible
  for shutting down the emulator) into EmuTarget.Stop after Shutdown is
  called.

- Renamed EmuTarget.Shutdown to _Shutdown since it's an implementation
  detail of EmuTarget.Stop(), and made it an empty implementation so
  that subclasses don't need to invoke it (implementations are
  necessarily specific to the subclasses). Among other things, this
  removes spurious log messages in qemu-specific code when shutting down
  fvdl-based emulators.

- FvdlTarget._ConnectToTarget now emits a log message before waiting for
  `fvdl` to finish starting to let the user know that something is
  happening.

- FvdlTarget._IsEmuStillRunning now returns False rather than throwing
  an exception if the emulator is stopped (e.g., via `ffx target off` or
  similar).

- Improve handling of IPv6 addresses as hosts in ffx_session.

- start_emulator.py now gives more explicit instructions to the user on
  how to point the test runner scripts at it, and makes it clear that
  Ctrl-C can be used to shut down the emulator. For example:

Emulator successfully started. You can now run Chrome Fuchsia tests with "-d --host 127.0.0.1 --port 60665" to target this emulator.
Type Ctrl-C in this terminal to shut down the emulator.

Bug: 1256502
Change-Id: I3a757c1062f929524723c3c84ab891215be825d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3540186
Reviewed-by: Benjamin Lerman <qsr@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/main@{#984291}