commit ecb614d4378818fe0309f97c4c0a893c73b96471
author Erik Chen <erikchen@chromium.org> Wed Sep 25 22:10:22 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 25 22:10:22 2024
tree 4390f32e0e758bffebe995f1332cb9e1cfa909ed
parent b03a68a6ea5d34022ea63904045ee6b39c6cb260

Reland 1: Remove TOP_ORIGIN_WITH_RESOURCE_EXCEPTIONS_SCOPE

The original CL had test logic that tried to run a RunLoop inside of an
idle-callback from the outer RunLoop. This fails on some platforms. The
test has been rewritten to not do this. The DOM can be briefly unusable
in the non-oopif setup. This edge case now has a check.

> Remove TOP_ORIGIN_WITH_RESOURCE_EXCEPTIONS_SCOPE.
>
> There are two content settings that used
> TOP_ORIGIN_WITH_RESOURCE_EXCEPTIONS_SCOPE: javascript and images. For
> most purposes, they were functionally equivalent to
> TOP_ORIGIN_ONLY_SCOPE because the implementation of
> GetPatternsFromScopingType replaced the secondary pattern with wildcard.
> The one exception is the content setting extension API, which allows
> extensions to set a non-wildcard secondary pattern. Metrics show that
> this functionality was hardly used and the functionality has already
> been disabled.
>
> The only effect of this CL is that extensions that attempt to set a
> different secondary pattern for the javascript and image content setting
> types will now encounter an error. For more details, see implementation
> of ContentSettingsContentSettingSetFunction::Run.
>
> This CL delete several tests which check behavior of secondary patterns
> for javascript, which is not behavior that can be encountered in the
> wild.
>
> Bug: 40282541

Bug: 40282541
Change-Id: I45d6de2ad164519119126ff4b7d68f5d325f4836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5855738
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1360211}