Google GitGoogle Git
Sign in
chromium/chromium/src/ece08cd7b0a59e7b035ea4f1977774c8abc00343
commit
ece08cd7b0a59e7b035ea4f1977774c8abc00343
[log]
author
Mehran Mahmoudi <mahmoudi@chromium.org>
Fri Sep 25 23:57:08 2020
committer
Commit Bot <commit-bot@chromium.org>
Fri Sep 25 23:57:08 2020
tree
d2771811bd78cd25641b27af32b1acafcaf32d35
parent
c2b4d7c7af969f9690e501333690ba84dab20078 [diff]
[Paint Preview] Disable toolbar hide on scroll when Paint Preview showing

This CL introduces the new PaintPreviewWindowAndroidHelper class. This
class stores activity-specific variables in PaintPreviewHelper. Using
the BrowserControlsManager class, it makes the top toolbar persistent
when a Paint Preview is shown.

This CL also fixes a bug where TabbedPaintPreviewPlayer#onDismiss was
never called.

Bug: 1131497
Change-Id: I3caf7017f601536ba03c1e1c60c9b024917f6063
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425433
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#810838}
3 files changed
tree: d2771811bd78cd25641b27af32b1acafcaf32d35
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .vpython
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.