commit | eced01fc9530674ca6b12d79b58bbac6faa8cc00 | [log] [tgz] |
---|---|---|
author | David Benjamin <davidben@chromium.org> | Wed Feb 27 18:29:02 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Feb 27 18:29:02 2019 |
tree | 1bb3b14156d692f4346cbd4d060812aae8fd9fd3 | |
parent | 7c6b3784929220f3a5528279f63a4e54869eb20d [diff] |
Make content::LoginDelegate single-thread and uniquely-owned This is a reland of https://chromium-review.googlesource.com/c/1388164 with a fix + hardening for a callback reentrancy bug. Diff patchset 1 to patchset 3 for the changes. Patchset 3 to 5 are rebase/commit message changes. This pushes the IO/UI hop to inside //content, which simplifies the callers. (Every caller is actually a UI thread object with an ad hoc IO thread proxy.) LoginDelegate itself is now uniquely-owned and the proxy is moved to inside ResourceDispatcherHost on the ResourceLoader path. On the network service path, we don't need a thread hop at all, so this simplifies things and saves a UI/IO round-trip. Bug: 908926 Change-Id: I2a38890f95b967f8739423d520e95a264289d267 Reviewed-on: https://chromium-review.googlesource.com/c/1457001 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Carlos IL <carlosil@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#636092}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .