Show glic window in attached state only for normal browsers Triggering the hotkey while a non-normal browser is active tries to open the glic window in the attached state. However, this hits a CHECK because the glic button isn't available to attach on non-normal browsers. This CL fixes this case by opening the glic window in the detached state instead. Fixed: 396240586 Change-Id: I7cdb49ffb74f474b357409abf8c2afaa6f329fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6262743 Reviewed-by: Ian Wells <iwells@chromium.org> Commit-Queue: Eshwar Stalin <estalin@chromium.org> Reviewed-by: Eshwar Stalin <estalin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1420193}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.