Google Git
Sign in
chromium / chromium / src / ecf3586f4634b57679df38148e2ef4293393685b
commitecf3586f4634b57679df38148e2ef4293393685b[log] [tgz]
authorAndrey Kosyakov <caseq@chromium.org>Wed May 18 18:46:12 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 18 18:46:12 2022
treed1f25f507eb52e0ec9bbda6f7dbc7a076782b65d
parente4723d126e1cbc72e579d8e8457d21cd3accf2ba [diff]
[m103] DevTools: omit loaderId in Page.navigate response when navigating same document

... because that's how the client is supposed to tell same-document navigation.
Reporting loaderId also doesn't make sense in this case because actual renderer
side loader id is going to be different (i.e. remain from the actual navigation
that caused the document to be loaded).

This was originally regressed by https://crrev.com/c/3640544

(cherry picked from commit 76d39453b92ffe19ed0c21f47a8e88130bc83821)

Bug: 1325782, 1324138
Change-Id: I4c528a55991b236394c68735b3c6319e350d1559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3649348
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1003895}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3653099
Commit-Queue: Prudhvikumar Bommana <pbommana@google.com>
Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#86}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
4 files changed
tree: d1f25f507eb52e0ec9bbda6f7dbc7a076782b65d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.