Google Git
Sign in
chromium / chromium / src / ed00ebefd8e6a1225b6117ff5add176c87f3cd29
commited00ebefd8e6a1225b6117ff5add176c87f3cd29[log] [tgz]
authorLei Zhang <thestig@chromium.org>Mon May 06 22:35:13 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 06 22:35:13 2024
tree08d9ecf064a6a6458c800e2e3f7fb6228f311a31
parent8ece67b78f4f93ad2c9d21f26ac4d2d5088edd89 [diff]
M125: Adjust PdfService sandbox type to prevent crashes

Change the sandbox type from `kService` back to `kUtility`, which is
the sandbox type used on Chrome OS when PdfService was part of
PrintingService. Then the sandbox will allow __NR_sysinfo and let code
execution proceed when PDFium calls into FreeType.

Add a test case for this scenario using an existing test PDF that can
trigger the crash.

(cherry picked from commit 508f1f09dab21aab3e96fd66e84b35ed620e7cd2)

Bug: 334272439
Change-Id: Iaf891aece171bb47362d959cb00080e5e4ba8ff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5503386
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1294784}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5517239
Cr-Commit-Position: refs/branch-heads/6422@{#739}
Cr-Branched-From: 9012208d0ce02e0cf0adb9b62558627c356f3278-refs/heads/main@{#1287751}
3 files changed
tree: 08d9ecf064a6a6458c800e2e3f7fb6228f311a31
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.