commit ed380dc4110d69543fcea84cd1a7465051ecbed7
author Devlin Cronin <rdevlin.cronin@chromium.org> Mon Jan 17 01:23:47 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Jan 17 01:23:47 2022
tree f78bfbe6faab309ed3807ff9db564685b01e1a7c
parent ebe57673d60cca0ef32493c164f75a4f86b72e0a

[Extensions] Remove LaunchContainer alias from constants.h

extensions/common/constants.h has a `using` declaration for
apps::mojom::LaunchContainer. I suspect this was added for ease of
migration from an enum to a mojo enum, but it has a number of drawbacks:
- Global `using` declarations are against Chromium/Google style
- It requires the include of a components/services/app_service file,
  in turn requires the //extensions/common:common_constants build target
  to depend on that component. This makes extracting out a "pure"
  extensions constants build component more complicated.

Remove the alias from //extensions/common/constants.h, and update all
relevant sites. This entails properly prefixing the variable and
including the mojom target as a build dependency for targets that depend
upon it (the latter is also good cleanup, since only a fraction of the
targets that depend upon //extensions/common:common_constants depend
upon this enum).

Bug: 1286881
Change-Id: Ib4a86d413508ab74f7c72d5c6d7ec13f8264b7c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3382235
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Caitlin Fischer <caitlinfischer@google.com>
Auto-Submit: Devlin Cronin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/main@{#959897}