[Blink] Make FallbackToSoftwareOnFailedTextureAlloc more precise

As the test is structured now, it looks like what is being verified is
that the call to `NewImageSnapshot()` causes a downgrade from GPU
rasterization to CPU rasterization. In fact, that is not what is
happening at all. Instead, it is the call to `DrawSomething()` that
causes the switch:

* Before this call there is no CanvasResourceProvider and so the host
  defaults to the preference that has been set
* This call causes a CanvasResourceProvider to be created. It is not
  possible to create a valid CanvasResourceProviderSharedImage without
  a GrDirectContext, and so the created CRP is unaccelerated. Hence,
  after this call the host will be using CPU rasterization.

This CL updates the test to make this flow precise, which will aid in
porting it to be a test on CanvasRenderingContext2D while being clear
about the functionality actually being tested.

I also removed an irrelevant expectation on
CanvasResourceHost::IsResourceValid() being true. This expectation
returns true here because no CC layer has been created, which doesn't
have anything to do with the rest of what the test is setting up and
checking.

Bug: 40280152
Change-Id: I59f10ff318fe7f5566e1d4b7a7421d8ded37c14d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5881979
Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1359371}
1 file changed
tree: c992595f94a2f34c451e576524ad604db544fb2c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitallowed
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. CPPLINT.cfg
  70. CRYPTO_OWNERS
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.