Google Git
Sign in
chromium / chromium / src / ed7c8c66f085a3630f4c584ddf2fdb9f1a052c80
commited7c8c66f085a3630f4c584ddf2fdb9f1a052c80[log] [tgz]
authordanakj <danakj@chromium.org>Mon Mar 07 15:47:44 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Mar 07 15:47:44 2022
treed0a334df2e833295dcdcd9a07bc3a75a0c89b302
parentd0c91737222f8b397952e8336869279bbd8f40d9 [diff]
Support GN public_deps for the Rust part of a mixed C++-Rust target

They are supported like other GN variables, by forwarding the
rs_public_deps variable through to the public_deps of the generated
rust_library().

This is important for component builds as a shared library links all
its `deps` and users of the shared library won't have access to them
unless they appear in `public_deps` (or the user adds them to their
own deps).

This is similar to C++ where gn check enforces that headers are not
used unless the target has a dependency on the header's target, either
directly or through public deps. In the future, with GN changes, GN
will enforce and support this correctly for Rust as well.

R=lukasza@chromium.org

Bug: 1296156
Change-Id: Ibaaf1f05c8338acac60ab351d077ef27cab5cab7
Cq-Include-Trybots: luci.chromium.try:android-rust-arm-rel,linux-rust-x64-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3503825
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: danakj <danakj@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#978279}
3 files changed
tree: d0a334df2e833295dcdcd9a07bc3a75a0c89b302
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.