commit ed9d68e8cf16e63bcd4146dee21dd83a777ba020
author Darren Shen <shend@chromium.org> Sun Feb 20 07:06:41 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sun Feb 20 07:06:41 2022
tree a679964feb8fbab1d0eebeeeb9387d8808411dc5
parent 513166417c10fbb6d6d24b30efa253181e0fd2d1

ime: Make OnFocus settings parameter optional.

In crrev/c/3418631, we added a new OnFocus Mojo method to repplace the
old one. Unfortunately, the old OnFocus had an optional settings param
but the new Mojo method has a mandatory settings param.

In the case where we pass nullptr to the new OnFocus, the connection
breaks and the user cannot type. Fortunately, we only pass nullptr
for certain input methods that are behind a flag.

To fix this, we will make the settings param optional. This will not
break existing code that passes non-null settings to OnFocus. In the
case where null is passed, this is still broken until we update the
other side of the Mojo API (in a separate repo). But that's okay
because it's behind a flag.

We did think about keeping the settings non-null. However, the
settings param is meant to be an extensible union. According to
crbug.com/1201949, extensible union params should be nullable anyway
for backwards compatibility.

BUG=b:209695253

Change-Id: I80f106449a368693c5c5d63bd855ed1a98e5616d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3473803
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Curtis McMullan <curtismcmullan@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/main@{#973336}