[Blink] Fix BaseRC2D::getImageData() to not end hibernation

The call to create a CanvasResourceProvider here is a no-op beyond
having the unfortunate side-effect of waking up the canvas if it's
hibernating:

If we don't have that check and we can't create a resource provider in
GetImage() [1] we'll end up here [2] with a null snapshot, which means
that we'll be returning exactly the same thing we're currently returning
in the "short-circuit if resource provider can't be created" codepath.

This CL removes the call to create the CRP and adds a regression test
that hibernation is preserved through a call to getImageData().

Note: This necessitates explicitly handling the case where GetImage()
returns null to ensure that the image that will be returned from
getImageData() is zero-initialized. Prior to this CL that case was (I
believe) not hit in practice because the cases in which GetImage()
would return null are effectively the same cases in which
GetOrCreateCanvasResourceProvider() would cause getImageDataInternal()
to short-circuit out earlier.

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc;l=658-660;drc=26fa5b6a22b36be60bc17cccd5754c44dcff3334
[2] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/canvas/canvas2d/base_rendering_context_2d.cc;l=585-587;drc=26fa5b6a22b36be60bc17cccd5754c44dcff3334

Bug: 40280152
Change-Id: I74096a85681de7c4d73dab4b357cb6c1055dbf7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6446396
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Jean-Philippe Gravel <jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1461187}
2 files changed
tree: 51bdcb81f212606c17be4b7e0ad62f6193ad68c5
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. SECURITY_OWNERS
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.