| commit | eda23dd182cb0435d35fca74a80f7806c5a7a6bb | [log] [tgz] |
|---|---|---|
| author | Mingyu Lei <leimy@chromium.org> | Thu Sep 14 02:00:46 2023 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Sep 14 02:00:46 2023 |
| tree | 3223254dae4215f7b77c3e86e5fd307055bb1289 | |
| parent | 63bc0524a14da2bc81efaa2b42914625d50b195a [diff] |
Revert "device_settings_policy: Add device policy for switching function keys" This reverts commit cf1926f2a1b428b7d38eb93aef601c2d25831fa4. Reason for revert: This fails chromium/ci/linux-presubmit with the following reason: Please add 'DeviceSwitchFunctionKeysBehaviorEnabled' to device_policy_proto_map.yaml and map it to the corresponding field in chrome_device_policy.proto. Original change's description: > device_settings_policy: Add device policy for switching function keys > > This CL adds a new device policy called > "DeviceSwitchFunctionKeysBehaviorEnabled". > > See c/p/r/t/p/M/DeviceSwitchFunctionKeysBehaviorEnabled.yaml in this > CL for a full definition of the policy. > > About half of this CL adds the policy, following the instructions at > https://chromium.googlesource.com/chromium/src/+/HEAD/docs/enterprise/add_new_policy.md. > The other half of this CL implements the policy, which controls the > behavior of the setting titled "Use the launcher key to change the > behavior of function keys". > > Screenshots: > Policy true: https://screenshot.googleplex.com/twYSXaMb5a8kTTf > Policy false: https://screenshot.googleplex.com/3HKJpTUuXKHLUUQ > Policy unset: https://screenshot.googleplex.com/B6ZjHXKeNEhfHPn > > Test: ash_unittests -f=*InputDeviceSettingsPolicyHandlerTest* > Test: components_unittests -f="*ConfigurationPolicyHandlerListTest*" > Test: browser_tests -f *PolicyPrefsTest.PolicyToPrefsMapping* > Test: ash_unittests -f=*KeyboardPrefHandler* > Bug: b/296618643 > Change-Id: I99523b8c9321f62ab649524f20cd4d33913a6a7c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4843777 > Reviewed-by: Anqing Zhao <anqing@chromium.org> > Reviewed-by: David Padlipsky <dpad@google.com> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Camden Bickel <cambickel@google.com> > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1196269} Bug: b/296618643, 1482560 Change-Id: I3b6e41707291bc369a893a0cc1738ee269d65c05 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4863721 Owners-Override: Mingyu Lei <leimy@chromium.org> Commit-Queue: Mingyu Lei <leimy@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1196373}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.