commit | edd0563c67445525fea31b817e79a82cef3d1eaa | [log] [tgz] |
---|---|---|
author | Christian Dullweber <dullweber@chromium.org> | Mon Sep 30 11:49:03 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 30 11:49:03 2024 |
tree | 1b017bda4241b8381e75ddb366538708250b8c14 | |
parent | 8d6e192341b437d157fd32850333e96201e11c20 [diff] |
Revert "Reland "Reland "[waffle]Don't show the dialog in a guest session if the pref is set""" This reverts commit af53608af082f3e5a5e4cfaa92f64eb6197d7d98. Reason for revert: I added the ifdefs in the wrong place https://ci.chromium.org/ui/p/chromium/builders/ci/Mac13%20Tests/21176/overview Original change's description: > Reland "Reland "[waffle]Don't show the dialog in a guest session if the pref is set"" > > This is a reland of commit 328052ff5cc3a07d33332b3f77513bb2e12d4295 > > Original change's description: > > Reland "[waffle]Don't show the dialog in a guest session if the pref is set" > > > > This is a reland of commit cf18d29dd6d004879f57685a452eb92bc1fe9f39 > > > > Original change's description: > > > [waffle]Don't show the dialog in a guest session if the pref is set > > > > > > The search engine choice dialog should not be displayed in all guest > > > sessions if the users decide to share the default search engine across > > > guest sessions. > > > > > > Demo: http://b/364254781#comment2 > > > Fixed: b:364254781 > > > Change-Id: I196b7c75b357fb351167e933f58d2ef777939e44 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5829416 > > > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > > > Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> > > > Auto-Submit: Jack Yammine <jyammine@google.com> > > > Cr-Commit-Position: refs/heads/main@{#1353983} > > > > Cq-Include-Trybots: luci.chromium.try:mac13-tests > > Change-Id: Ic886af24761256c90c14640c0bdad7cb020c3660 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5891297 > > Auto-Submit: Christian Dullweber <dullweber@chromium.org> > > Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> > > Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1361083} > > Change-Id: I5e8d7bef9a461ca410aab08a07190b4187082835 > Cq-Include-Trybots: luci.chromium.try:mac13-tests > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5893497 > Commit-Queue: Christian Dullweber <dullweber@chromium.org> > Auto-Submit: Christian Dullweber <dullweber@chromium.org> > Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1361709} Change-Id: I90d411ed1c98b69d344510798736568c4a443106 Cq-Include-Trybots: luci.chromium.try:mac13-tests No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5898733 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Owners-Override: Tom Van Goethem <tov@chromium.org> Auto-Submit: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/main@{#1361740}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.