Google Git
Sign in
chromium / chromium / src / eddc4cbb0bdec59c91debc137fb5836eb9ffa3b4
commiteddc4cbb0bdec59c91debc137fb5836eb9ffa3b4[log] [tgz]
authorJames Cook <jamescook@chromium.org>Wed Jul 21 19:55:27 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 21 19:55:27 2021
treed2a1607a2f9ef249c767dc1768ef10876442a898
parentb3b976a978a88120096ceef4c14a7d69427cd45e [diff]
Reland: AppListBubble: Use existing assistant page tests with bubble launcher

Original CL:
https://chromium-review.googlesource.com/c/chromium/src/+/3033293

Changes for reland:
When opening assistant page, wait for the page to be drawn
and laid out. Reuse ViewDrawnWaiter from some holding space tests to
do this. This eliminates test flake in release builds.

Original CL description:
Parameterize most tests to run with and without feature kAppListBubble.
Move tests that only apply to the existing "peeking" launcher into
their own test suite.

Fix light/dark mode for bubble launcher to make one of the tests
pass.

Bug: 1229427
Test: existing ash_unittests
Change-Id: Iec0129f6c5060636e21fce8e08ab7ef7dbe6db19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3042120
Reviewed-by: Jeffrey Young <cowmoo@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#904005}
11 files changed
tree: d2a1607a2f9ef249c767dc1768ef10876442a898
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.