commit eddea02d99e5caecf0ce0244cf394ccd6c7e1e87
author Hayato Ito <hayato@chromium.org> Tue May 28 00:55:19 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue May 28 00:55:19 2024
tree cf1007f8d5bca69fade0dd72ca11ec6e1a9f75e0
parent 8027306ec1ba15b4bc505ac08191288362a782a0

Reland "[URL] Make CSPSourceTest pass with non-special URL feature"

This is a reland of commit 7ab6175da13673b73e7d0dde4e0b589763528d46

No change from the reverted CL. The issue is probably in a different
CL. See https://crrev.com/c/5569881 for details.

Original change's description:
> [URL] Make CSPSourceTest pass with non-special URL feature
>
> There are a few tests in CSPSourceTest, namely AllowScheme and
> CustomSchemeWithHost, that would break when we enable the
> StandardCompliandNonSpecialSchemeURLParser feature [^1][^2]:
>
> They fail because, with the feature enabled, url.host() now correctly
> returns the host part for non-special URLs. Previously, it always an
> empty string for non-special URLs.
>
> This CL updates `SourceAllowHost` (defined in csp_sources.cc) to
> preserve the current behavior of CSP when the feature is enabled.
>
> I and reviewers agreed that the current behavior is not desired, but
> decided to preserve the status-quo for now so that we can ship the
> feature without being affected by a change to CSP at the same time.
>
> [^1]:
> https://ci.chromium.org/ui/p/chromium/builders/try/linux-rel/1752691/test-results
> [^2]:
> https://docs.google.com/spreadsheets/d/1Pqw1iKXK_lxHj-kLIAeRFs-khFz-BPZDio1W7SgEVE4/
>
>
> Bug: 40063064
> Change-Id: I2bb4ea179efae2e6d2217a24c81eaec3ab71cdd9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5528336
> Commit-Queue: Hayato Ito <hayato@chromium.org>
> Reviewed-by: Antonio Sartori <antoniosartori@chromium.org>
> Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1304834}

Bug: 40063064
Change-Id: I2bbdefef6a3fe1c66b4eb34414e5e4f944058739
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5569363
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1306556}