| commit | ee0d5036bd0e66b2550cdf06aade7e30a347bac6 | [log] [tgz] |
|---|---|---|
| author | Hiroki Nakagawa <nhiroki@chromium.org> | Thu Oct 31 15:35:39 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Oct 31 15:35:39 2024 |
| tree | e5f43a58608c4e437f5cc93ef89ffdcf7a2fb5eb | |
| parent | 5fe76ceb0964d50bc603c417fcc4851f37de04a2 [diff] |
Move GWSPageLoadMetricsObserver from chrome/ to components/ This is a preparation for running GWSPageLoadMetricsObserver on WebView. Before this CL, the observer was placed in chrome/ that WebView (android_webview/) cannot access. This CL moves the observer to components/ that can be accessed from android_webview/. GWSPageLoadMetricsObserver had dependencies on chrome specific utilities to record kSuffixIsBrowserStarting and kSuffixFromNewTabPage. These cannot be migrated to components/, so this CL leaves them in chrome/ as ChromeGWSPageLoadMetricsObserver: - kSuffixIsBrowserStarting: AfterStartupTaskUtils is used for checking if the browser is still starting. Currently this utility is not available in components/, so this suffix needs to be kept in chrome/. - kSuffixFromNewTabPage: chrome::kChromeUINewTabPageURL is available only in chrome/. Also, WebView doesn't have the NTP, so this suffix should be kept in chrome/. In follow-up CLs, WebView will use GWSPageLoadMetricsObserver, not ChromeGWSPageLoadMetricsObserver. This means metrics with these suffixes won't be recorded for WebView. Change-Id: I3ac28f4240b18585cc41eae657c4f00ca6b0f161 Bug: 376094913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5973517 Reviewed-by: Peter Kasting <pkasting@chromium.org> Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Shunya Shishido <sisidovski@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/main@{#1376332}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.