Google Git
Sign in
chromium / chromium / src / ee93710e09b0bc7d56668d0f06b85dfce21495fd
commitee93710e09b0bc7d56668d0f06b85dfce21495fd[log] [tgz]
authorDarren Shen <shend@chromium.org>Fri Jan 04 02:43:59 2019
committerCommit Bot <commit-bot@chromium.org>Fri Jan 04 02:43:59 2019
treebf8c87c038d867ba988e7856c3be83089a11e2aa
parent05ab1c1c2d47097a815d665ae24b50817b573ec5 [diff]
[emoji] Remove emoji option from Mojo apps.

Currently right-clicking on input fields in Mojo apps will bring up
an emoji option. Clicking it would crash the app. This is because we
assume that an emoji callback function always exists, but actually this
is not true for Mojo apps because they are in a different process.

This patch adds a null check for the emoji callback so that we don't
show the emoji option when we don't have a callback.

Bug: 887649
Change-Id: Iaccb0d9f890187f5c405888babefde7d3f33abe0
Reviewed-on: https://chromium-review.googlesource.com/c/1393584
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619868}
2 files changed
tree: bf8c87c038d867ba988e7856c3be83089a11e2aa
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. jingle/
  30. mash/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. webrunner/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .