commit | eebb881b3b99ade3c4567cd996f4b4719342dd13 | [log] [tgz] |
---|---|---|
author | Michelle <michellegc@google.com> | Mon Feb 05 07:07:53 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Feb 05 07:07:53 2024 |
tree | 6b9df154b3a53f479fd01e31de27e8fdd9a0aa8d | |
parent | 272d9962bc491b3fbaaff6bc10d6d469364a3526 [diff] |
Use fallback Picker anchor bounds if caret is outside focused window. CL:5261480 adds logic to anchor the Picker view at the mouse cursor as a fallback when the text caret bounds are not available (or empty). There are also situations where caret bounds can be non-empty but still invalid, e.g. Google docs places the "caret bounds" offscreen, far away from the visible text location. In these cases, it's probably better to just anchor the Picker at the mouse cursor rather than the bogus caret bounds. As a heuristic to handle these situations, add an extra condition to anchor at the fallback cursor point when the caret bounds are not contained in the current focused window. Bug: b:322910874 Change-Id: Iab03634930235de4b3a4a23d9f18475e1a24311e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5267200 Commit-Queue: Michelle Chen <michellegc@google.com> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/main@{#1256073}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.