| commit | eed320ecc8d9a283f9cde7adfb98e54c6bf40470 | [log] [tgz] |
|---|---|---|
| author | Javier Fernández García-Boente <jfernandez@igalia.com> | Wed Jun 09 08:22:40 2021 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jun 09 08:22:40 2021 |
| tree | 6870f44e7d09eeeda66d7efcf08d1abb48c8688c | |
| parent | f0bb1ac23e604b5ae1552d189feb275070adf675 [diff] |
Ensure fragment tree consistency just after subtree layout The CL landed in r876527 implemented a performance optimization of the subtree layout logic. The idea was to avoid rebuilding the fragment tree spine of a common ancestor of several subtree roots. However, this change caused a regression that lead to inconsistent fragment tree, only solvable by using the PostLayout() logic. This solution is not ideal, since it doesn't address the root cause of the fragment tree inconsistency. This CL addresses the root cause by getting back to the original approach implemented in the subtree layout logic, consisting on ensuring the tree consistency after performing the subtree layout process. In order to avoid the perf regression we use counter of the number of roots with a common ancestor; only after all these root have completed their layout we'll perform the fragment tree spine rebuild. Bug: 1214198 Change-Id: Ia996bc1538984f849dcd5a781c771150058a201e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2934743 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#890653}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.