| commit | eeee643ae963e1d78c7457184f8af93f48bba9d3 | [log] [tgz] |
|---|---|---|
| author | David Bienvenu <davidbienvenu@chromium.org> | Mon Sep 14 17:48:57 2020 |
| committer | Commit Bot <commit-bot@chromium.org> | Mon Sep 14 17:48:57 2020 |
| tree | c0423a6bd912cc90a2c558cd53223b8079af4bcb | |
| parent | 4e7cbac195f9618d60d7c24988ef7a39263a38ef [diff] |
Fix handling of failure case of IsWindowOnCurrentVirtualDesktop If the IVirtualDestkopManager COM method IsWindowOnCurrentVirtualDesktop fails on a window, treat the window as non-occluding, because that's safer than treating it as occluding - it might be on an another virtual desktop, and thus should be non-occluding. Previously, IsWindowOnCurrentVirtualDesktop was incorrectly returning base::Optional nullopt on Windows 7 and 8.1 (i.e., unknown). This CL makes it return true, because there are no virtual desktops on Win 7/8, so every window is on the current desktop. This allows us to require that IsWindowOnCurrentVirtualDesktop return true to say that a window is occluding - previously we checked for != false, to handle Win7. Bug: 813093 Change-Id: Iee49eff9333a8530314720702b1815256acdbfc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410420 Reviewed-by: Jesse McKenna <jessemckenna@google.com> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806683}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.