view-transition: Fix snapshot CB calculation on Android

As a result of https://crbug.com/1478653, the snapshot root calculation
was changed to be based on LayoutView::ClientWidth/Height. This seems to
be the correct way to access the layout-computed content area,
accounting for a scrollbar-gutter. However, this broke the case where a
page is wider than its initial-containing-block. In that case, the
LayoutView will be (much) smaller than the FrameView but the FrameView
is what's filling the visual viewport (when fully zoomed out).

This CL restores the FrameView-based calculation removed by fixing bug
1478653 but keeps the LayoutView calculation if ViewportEnabled is off,
that is, the computation depends on whether or not the FrameView and
LayoutView can differ in size (this is effectively an IsAndroid switch).
I don't think there's currently a simple value for this in the layout
system. While not the most satisfying fix, scrollbar-gutters and
viewport-behavior are mutually exclusive as the latter implies
non-zoomable overlay scrollbars.

This fixes the DCHECKs being tripped in 1495157 which revealed the
problem. It also removes the DCHECKs about the snapshot root being
smaller than the max texture size. The fixed viewport can be up to 4
times the size of device viewport (since the absolute minimum scale
allowed is 0.25) which can sometimes exceed the max texture size.

Bug: 1495157,1478653
Change-Id: I50131732d8830c1d4bb2f64a1d12186507a84e62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5009491
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Auto-Submit: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1223863}
7 files changed
tree: ac56b9182c17165d51976f7f101e2b8ce79b17d6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.