| commit | eeefec46db99151f00abb30e74bfcea5dbbc61cf | [log] [tgz] |
|---|---|---|
| author | Frank Li <frankli@microsoft.com> | Wed Mar 09 01:13:53 2022 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Mar 09 01:13:53 2022 |
| tree | 7830dff5e8105c6cf57a9f88331e522bec3eca6f | |
| parent | 4595c36e6b78a5ce99629f78a0b88e5ea22af466 [diff] |
media: Add patterned DroppedFrameCount2/FrameReadBackCount UMAs
This CL adds patterned UMAs to monitor DroppedFrameCount2 and
FrameReadBackCount based on RendererType for video playbacks, e.g. the
MediaFoundationRenderer from MF Frame Server Mode Clear video playbacks.
For DroppedFrameCount2, it is also patterned with Clear/Encrypted.
FrameReadBackCount only applies to Clear video playback.
UMAs added:
- Media.DroppedFrameCount2.{RendererType}.{ClearOrEncrypted}
- Media.FrameReadBackCount.{RendererType}
Manually tested by exercising canvas/video playbacks with/without
enabling of `chrome://flags/#enable-media-foundation-clear`. The
followings are reported/verified in about://histograms:
```
// chrome://flags/#enable-media-foundation-clear enabled:
- Histogram: Media.DroppedFrameCount2.MediaFoundationRenderer.Clear recorded 1 samples, mean = 0.0 (flags = 0x41) [#]
0 -O (1 = 100.0%)
1 ...
- Histogram: Media.FrameReadBackCount.MediaFoundationRenderer recorded 1 samples, mean = 2699.0 (flags = 0x41) [#]
0 ...
2008 -O (1 = 100.0%) {0.0%}
2786 ...
// chrome://flags/#enable-media-foundation-clear disabled:
- Histogram: Media.DroppedFrameCount2.RendererImpl.Clear recorded 1 samples, mean = 0.0 (flags = 0x41) [#]
0 -O (1 = 100.0%)
1 ...
- Histogram: Media.DroppedFrameCount2.RendererImpl.Encrypted recorded 1 samples, mean = 0.0 (flags = 0x41) [#]
0 -O (1 = 100.0%)
1 ...
- Histogram: Media.FrameReadBackCount.RendererImpl recorded 1 samples, mean = 1084.0 (flags = 0x41) [#]
0 ...
1043 -O (1 = 100.0%) {0.0%}
1447 ...
```
Bug: 1258887
Change-Id: I23c1e81aef66e9bd555fbd2dc0add61a610bd7e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3501242
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Frank Li <frankli@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#978997}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.