[bindings] Isolatify ScriptState::From(..) and friends
... in order to shave off unnecessary instructions from hot paths here
and there.
This CL introduces:
- ScriptState::ForCurrentRealm(v8::Isolate*),
- ScriptState::ForRelevantRealm(v8::Isolate*, v8::Local<v8::Object>),
- ScriptState::From(v8::Isolate*, v8::Local<v8::Context>),
- ScriptState::MaybeFrom(v8::Isolate*, v8::Local<v8::Context>).
Removes:
- ScriptState::ForRelevantRealm(v8::Isolate*, v8::Local<v8::Object>),
- ScriptState::From(v8::Local<v8::Context>),
- ScriptState::MaybeFrom(v8::Local<v8::Context>)
in favour of version with isolate parameter.
Additionally
- ScriptState::ForRelevantRealm(..) is used instead of
ScriptState::From(.., obj.GetCreationContext()),
- ScriptState::Current(v8::Isolate*) is removed in favour of
ScriptState::ForCurrentRealm(v8::Isolate*) - for uniformity,
- V8PerContextData::From(context) is removed in favour of
script_state->PerContextData().
This CL brings ~0.2-0.7% on Speedometer2 and Speedometer3.
performance.
Binary-Size: We accept binary size increase as a trade-off for
Bug: 336738728
Change-Id: I84cfc39fec33f9199b1af3225ce1706e3cdbe922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5513325
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Igor Sheludko <ishell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1297472}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.