[GM3] Moving Panorama color picker to cr_component The start of the html and css was copied over in https://chromium-review.googlesource.com/c/chromium/src/+/4652259. This is largely a moving over (with a little copying) of code to make the theme color selector from the Customize Chrome side panel reusable in Settings. There is also cleanup so that CustomizeChromePageHandler doesn't have unused methods and mojom data after the removal. Notable changes or things I felt might need explaining in the cleanup have a comment on them to help make this easier to navigate. In this CL: * Anything needed from CustomizeChromePageHandler and the associated mojom file were moved over to ThemeColorPickerHandler. The only color related code that there is still a copy of in CustomizeChromePageHandler is foreground and background colors in the Theme object and 2 methods for resetting to Classic Chrome. * Colors.html, colors.ts, color.html, color.ts were all copy pasted over with just a changing of names and then deleted. This is also on top of renaming them from their name from the first CL. Check_mark_wrapper.ts and check_mark_wrapper.html were also copied over for use. A copy was left behind for use by other Customize Chrome Side Panel elements. * ChromeColorsElement was left where it is since it has no plans to be reused and might end up being removed entirely. However, it is now connected to the new handler so it can still use all of the methods it depended on. * Unit tests and browser tests were also moved/copied over as needed. Browser tests should all be moved other than the check_mark_wrapper, which is a copy. Unit tests are a mix to match the movement done in the page handlers themselves. * The rest of it is bindings, inserting it into the side panel, OWNERS, and BUILD related changes. customize_chrome_colors.cc. It didn't have tests before and it doesn't make sense for it to have tests. It build an array on build time for use in other files. Low-Coverage-Reason: The only low coverage file is Bug: 1459420 Change-Id: Ic1111f388452d833ad4e63dc6ee52543064daf13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4676662 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: John Lee <johntlee@chromium.org> Commit-Queue: Riley Tatum <rtatum@google.com> Reviewed-by: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/main@{#1175721}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.