commit ef730b569fe7fd6b123db35d0cdab5a0c5d47f3a
author Kavita Soni <kavitasoni@chromium.org> Sat Aug 03 00:30:23 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Sat Aug 03 00:30:23 2024
tree 056ed4292c86d8d535674e20e2d28863b2195ef2
parent 8efd5654b1ca370f3f3282aa46986c192658cf2b

Fix save card infobar crash when reshown on ios.

Before this change, when save card infobar in loading state is closed
and reshown through omnibox icon, it is not updated to show the
confirmation and also causes chrome to crash when mediator tries to
autoclose the infobar after post confirmation. Reason being, the view
is now handled by a new mediator that is allocated upon reshow and the
delegate still holds a callback to the old mediator.

This CL, updates the mediator's callback reference in the delegate
each time a new mediator is allocated. Adds a safety check in the
mediator's `saveCardDelegate` to verify if the `config` exists which
could be a nullptr due to request being deleted on infobar dismissal.
Also informs the delegate each time infobar is presented or dismissed.

Screencast with the fix: http://go/scrcast/NjM0NzM5OTYzODI4NjMzNnwxYmM0ZjY3ZC1kYw
Screencast without the fix: http://go/scrcast/NTMyODI3MjYxODQyMjI3MnxjNjExZThiMC1iNw

Bug: 339887700, 355661465, 356208501
Change-Id: I652f7322a6eb1485723e3b783c2526f9df7d017b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5753227
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Slobodan Pejic <slobodan@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Kavita Soni <kavitasoni@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1336884}