Google Git
Sign in
chromium / chromium / src / efdf77aa6ae3a754ab34c30d6d324ffa68865c9e
commitefdf77aa6ae3a754ab34c30d6d324ffa68865c9e[log] [tgz]
authorAndy Phan <andyphan@chromium.org>Thu May 04 17:21:45 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu May 04 17:21:45 2023
treebfc96755601d98cea13317320d4f385e3c8d9a20
parent59b749dbe7da2109065a364df0af367c2ae79e0c [diff]
Reland "Add browser tests for extension printer printable area"

Add specific test results for macOS, which is different from other
platforms.

This is a reland of commit 05e51b67f601653b835c824953afe80abc9682ad

Original change's description:
> Add browser tests for extension printer printable area
>
> There are no browser tests that cover extension printer handling code.
> Modify the test printer extension to implement the
> chrome.printerProvider API and provide dummy extension printers. In
> tests, add the extension printer ids to sticky settings, which will
> cause Print Preview to request extension printers. This will trigger
> extension printer handling code.
>
> This setup would have allowed us to catch crbug.com/1432309 if an
> extension printer with missing printable area was provided.
>
> Bug: 1432309
> Change-Id: Ib58b45c7e2346850d79fe6be71989f095a9b01a3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4443019
> Reviewed-by: Alan Screen <awscreen@chromium.org>
> Commit-Queue: Andy Phan <andyphan@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1138162}

Bug: 1432309
Change-Id: Ie89a75a1ddcde65a48dc0f8136b3fe9933e403de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4499575
Reviewed-by: Alan Screen <awscreen@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1139637}
3 files changed
tree: bfc96755601d98cea13317320d4f385e3c8d9a20
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.